trying a 'load all collections' default in mongodb

package.json

 {
   "name": "darc-mongoreadyserver",
-  "version": "0.1.18",
+  "version": "0.1.19",
   "description": "A \"MongoDB ready\" server",
   "main": "src/index.js",
   "scripts": {
@@ -8,12 +8,13 @@
   },
   "author": "W. Ross Morrow",
   "license": "Apache-2.0",
+  "repository":"https://code.stanford.edu/morrowwr/darc-mongoreadyserver",
   "dependencies": {
     "axios": "^0.19.2",
     "body-parser": "^1.19.0",
     "cors": "^2.8.5",
     "daat-coordinator": "^1.0.6",
-    "darc-mongoreadyserverconfig": "^0.1.3",
+    "darc-mongoreadyserverconfig": "^0.1.4",
     "express": "^4.17.1",
     "log4js": "^6.1.1",
     "mongodb": "^3.5.2",

src/mongodb.js

@@ -76,7 +76,7 @@ const loadMongoDBClient = ( config ) => {
 		// local variables
 		var col = { } , waitingForDB , waitingTimer;
 
-		// set "global" variables
+		// define collection names to search for
 		if( config.mdb.names ) {
 			mongodbNames = { ...mongodbNames , ..._config.mdb.names };
 		}
@@ -89,7 +89,8 @@ const loadMongoDBClient = ( config ) => {
 		} , 1000 );
 
 		// connect to MongoDB
-		_mongodb.MongoClient.connect( config.mdb.uri , { useNewUrlParser: true , useUnifiedTopology: true } , function ( err , client ) {
+		let mdbOptions = { useNewUrlParser: true , useUnifiedTopology: true };
+		_mongodb.MongoClient.connect( config.mdb.uri , mdbOptions , ( err , client ) => {
 
 		    if( err ) { return reject(err); }
 
@@ -105,59 +106,63 @@ const loadMongoDBClient = ( config ) => {
 	    		// list of collection names
 	    		var names = items.map( i => i.name );
 
-	    		// this is the list of __ desired __ collections __ missing __ 
-	    		var missing = Object.values( mongodbNames ).filter( (i) => ( names.indexOf(i) <  0 ) );
+	    		if( _config.mdb.names ) {
 
-	    		// process different possibilities
-	    		if( missing.length === 0 ) {
+		    		// this is the list of __desired__ collections __missing__ 
+		    		var missing = Object.values( mongodbNames ).filter( (i) => ( names.indexOf(i) < 0 ) );
 
-			    	// define the collection references
-			    	Object.keys( mongodbNames ).forEach( c => {
-			    		// wrapper reference for each collection "c", named "mongodbNames[c]" in this MongoDB instance
-			    		col[c] = client.db( config.mdb.db ).collection( mongodbNames[c] );
-			    		// log that we loaded this collection
-			    		_log.info( `  Loaded collection "${c}" (from ${mongodbNames[c]})` );
-			    	} );
+		    		// process different possibilities... 
+		    		if( missing.length === 0 ) { // there are NO missing collections
 
-		    		// we're done
-		    		resolve( { client : client , col : col } );
+				    	// define the collection references
+				    	Object.keys( mongodbNames ).forEach( c => {
+				    		// wrapper reference for each collection "c", named "mongodbNames[c]" in this MongoDB instance
+				    		col[c] = client.db( config.mdb.db ).collection( mongodbNames[c] );
+				    		// log that we loaded this collection
+				    		_log.info( `  Loaded collection "${c}" (from ${mongodbNames[c]})` );
+				    	} );
 
-	    		} else {
+			    		// we're done
+			    		resolve( { client : client , col : col } );
 
-	    			let done = 0 , todo = Object.keys( mongodbNames ).length;
+		    		} else { // there are SOME missing collections
 
-			    	// define the collection references
-			    	Object.keys( mongodbNames ).forEach( c => {
+		    			let done = 0 , todo = Object.keys( mongodbNames ).length;
 
-			    		if( missing.indexOf( mongodbNames[c] ) >= 0 ) {
+				    	// define the collection references
+				    	Object.keys( mongodbNames ).forEach( c => {
 
-			    			// create collection... is the callback ok? need coordinator? 
-			    			client.db( config.mdb.db ).createCollection( mongodbNames[c] , ( error , newcol ) => {
-			    				// wrapper reference for each collection "c", named "mongodbNames[c]" in this MongoDB instance
-			    				col[c] = newcol;
-					    		// log that we created this collection
-					    		_log.info( `  Created collection "${mongodbNames[c]}" (for ${c})` );
-					    		// 
-					    		done += 1;
-					    		//
-					    		if( done == todo ) { resolve( { client : client , col : col } ); }
-			    			} );
+				    		if( missing.indexOf( mongodbNames[c] ) >= 0 ) { // collection does NOT exist
 
-			    		} else {
+				    			// create collection... is the callback ok? need coordinator? 
+				    			client.db( config.mdb.db ).createCollection( mongodbNames[c] , ( error , newcol ) => {
+				    				// wrapper reference for each collection "c", named "mongodbNames[c]" in this MongoDB instance
+				    				col[c] = newcol;
+						    		// log that we created this collection
+						    		_log.info( `  Created collection "${mongodbNames[c]}" (for ${c})` );
+						    		// 
+						    		done += 1; if( done == todo ) { resolve( {client:client,col:col} ); }
+				    			} );
 
-				    		// wrapper reference for each collection "c", named "mongodbNames[c]" in this MongoDB instance
-				    		col[c] = client.db( _config.mdb.db ).collection( mongodbNames[c] );
-				    		// log that we loaded this collection
-				    		_log.info( `  Loaded collection "${c}" (from ${mongodbNames[c]})` );
-				    		// 
-				    		done += 1;
-				    		//
-				    		if( done == todo ) { resolve( { client : client , col : col } ); }
+				    		} else {
+
+					    		// wrapper reference for each collection "c", named "mongodbNames[c]" in this MongoDB instance
+					    		col[c] = client.db( _config.mdb.db ).collection( mongodbNames[c] );
+					    		// log that we loaded this collection
+					    		_log.info( `  Loaded collection "${c}" (from ${mongodbNames[c]})` );
+					    		// 
+						    	done += 1; if( done == todo ) { resolve( {client:client,col:col} ); }
+
+				    		}
 
-			    		}
+				    	} );
+						
+		    		}
 
-			    	} );
-					
+	    		} else {
+	    			names.forEach( c => {
+	    				col[c] = client.db( _config.mdb.db ).collection( c )
+	    			} );
 	    		}
 
 	    	} );