syncs: move sync package installation into sync scrpts

manifests/sync_scripts.pp

@@ -17,6 +17,9 @@ class su_ldap::sync_scripts (
   $enable_ldap_reports                = false,
 ) {
 
+  # install the sync scripts package first
+  package{ 'libstanford-ldap-sync-scripts-perl': ensure => installed }
+
   ## First, a single ketab for all this stuph
   # this is the sync keytab ticket, for service/ldap-$env
   $k5start_service_name  = "k5start-ldap-sync-$env"

manifests/sync_scripts/ldap_sync_sugal_attributes.pp

@@ -3,7 +3,7 @@
 #
 # See also https://ikiwiki.stanford.edu/service/ldap/sync-scripts/
 
-class s_ldap::base::syncs::ldap_sync_sugal_attributes  (
+class su_ldap::sync_scripts::ldap_sync_sugal_attributes  (
   $ensure       = undef,
   $ldap_master_fqdn = undef,
   $env = undef,
@@ -22,7 +22,7 @@ class s_ldap::base::syncs::ldap_sync_sugal_attributes  (
   ## Load the package containing the ldap-sync-sugal-attributes script.
   #package { 'libstanford-directory-sync-sugal-perl':
   #  ensure  => installed,
-    #require => Package['slapd'],
+  #  require => Package['slapd'],
   #}
 
   # Install the configuration file for the listener
@@ -52,7 +52,7 @@ class s_ldap::base::syncs::ldap_sync_sugal_attributes  (
     require => File['/etc/ldapadmin/ldap-sync-sugal-attributes.conf'],
   }
 
-  # Nah, stretch has systemd built in
+  # In sync_scripts.pp
   ## Service (listener)
   #  include s_ldap::base::systemd
 
@@ -70,7 +70,8 @@ class s_ldap::base::syncs::ldap_sync_sugal_attributes  (
     ensure  => $service_status,
     require => [
       File['/lib/systemd/system/ldap-sync-sugal-attributes.service'],
-      Package['libstanford-directory-sync-sugal-perl'],
+      # Package['libstanford-directory-sync-sugal-perl'],
+      Package['libstanford-ldap-sync-scripts-perl'],
     ],
   }