fix more @ issues in ERB files

NEWS

+UNRELEASED (2015-03-??)
+
+    Fix a few more deprecation warnings concering instance variables
+    (i.e., add '@'s in ERB files) (adamhl)
+
 release/004.031 (2015-03-02)
 
     Beginning of work to support RHEL-ish operating systems
-    such as CentOS and Oracle Linux. The most common change 
+    such as CentOS and Oracle Linux. The most common change
     involves converting 'operatingsystem' variable/fact usage
-    to 'osfamily'. These changes were made safely as not to 
+    to 'osfamily'. These changes were made safely as not to
     potentially affect any existing hosts. There may be some
     additional refinements when CentOS and Oracle hosts come
     online; for now,  we're assuming they act identical to RHEL.
-    
+
     Additionally modified puppetclient.pp to support version
     locking of puppet and facter versions on RHEL systems.
     Added one additional manifest to facilitate this.

templates/kerberos/krb5.conf.erb

@@ -53,7 +53,7 @@
 
 [realms]
     stanford.edu = {
-<% if drSite == "yes" %>        kdc            = kerberos-liv.stanford.edu:88
+<% if @drSite == "yes" %>        kdc            = kerberos-liv.stanford.edu:88
 <% end %>        kdc            = krb5auth1.stanford.edu:88
         kdc            = krb5auth2.stanford.edu:88
         kdc            = krb5auth3.stanford.edu:88

templates/newsyslog/config.erb

@@ -5,7 +5,7 @@ set save    = <%= @directory %>/OLD/%n
 set archive = <%= @archive %>/%Y/%M/%d/%m.%n
 <% end -%>
 
-<%= name %> {
+<%= @name %> {
 <% if @stop != '' then -%>
     stop: <%= @stop %>
 <% end -%>

templates/os/motd.erb

@@ -10,7 +10,7 @@
 
     host = @fqdn.downcase
 
-    product = productname rescue nil
+    product = @productname rescue nil
     if product.nil?
       product = "unknown"
     else