From c6b28a0da282e6506212968d2dea2878434b6245 Mon Sep 17 00:00:00 2001 From: Adam Henry Lewenberg <adamhl@stanford.edu> Date: Wed, 18 Jul 2018 08:41:59 -0700 Subject: [PATCH] fix require parameter for absent newsylog::config resources --- manifests/newsyslog/config.pp | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/manifests/newsyslog/config.pp b/manifests/newsyslog/config.pp index 8b45eee..c0e3f17 100644 --- a/manifests/newsyslog/config.pp +++ b/manifests/newsyslog/config.pp @@ -80,9 +80,20 @@ define base::newsyslog::config( $save_num = '15' ) { if $name !~ /^\w+$/ { fail ("'${name}' contains an invalid character.") } - file { "/etc/newsyslog.${frequency}/${name}": - ensure => $ensure, - content => template('base/newsyslog/config.erb'), - require => Package['newsyslog'], + + if ($ensure == 'present') { + file { "/etc/newsyslog.${frequency}/${name}": + ensure => $ensure, + content => template('base/newsyslog/config.erb'), + require => Package['newsyslog'], + } + } else { + # We separate out the absent since we don't want to + # require the newyslog package if we are ensuring this + # configuration is absent. + file { "/etc/newsyslog.${frequency}/${name}": + ensure => absent, + } } + } -- GitLab