From 6fd31cba2b75712133fa4576b5dda978c212d690 Mon Sep 17 00:00:00 2001
From: Adam Henry Lewenberg <adamhl@stanford.edu>
Date: Thu, 22 Feb 2018 10:01:55 -0800
Subject: [PATCH] fix crit calls

---
 NEWS                                    | 3 +++
 manifests/apt_key/key.pp                | 2 +-
 manifests/iptables/fragment_template.pp | 2 +-
 manifests/up2date.pp                    | 2 +-
 manifests/wallet/keytab.pp              | 2 +-
 5 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/NEWS b/NEWS
index 21b0136..3e465cb 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,8 @@
 unreleased (207x-xx-xx)
 
+    [several] change 'crit "stuff"' to 'crit("stuff")' to make Puppet 5
+    happy. [adamhl]
+
     [out_of_date] Add some parameters to the interface to make it easier
     to point at different out-of-date servers. [adamhl]
 
diff --git a/manifests/apt_key/key.pp b/manifests/apt_key/key.pp
index c8c65e4..4b78749 100644
--- a/manifests/apt_key/key.pp
+++ b/manifests/apt_key/key.pp
@@ -17,7 +17,7 @@ define base::apt_key::key($ensure) {
       }
     }
     default: {
-      crit "Invalid ensure value: $ensure"
+      crit("Invalid ensure value: $ensure")
     }
   }
 }
diff --git a/manifests/iptables/fragment_template.pp b/manifests/iptables/fragment_template.pp
index c8ac4de..ff0f93b 100644
--- a/manifests/iptables/fragment_template.pp
+++ b/manifests/iptables/fragment_template.pp
@@ -54,7 +54,7 @@ define base::iptables::fragment_template($ensure,
         }
 
         default: {
-            crit "Invalid ensure value: $ensure"
+            crit("Invalid ensure value: $ensure")
         }
     }
 }
diff --git a/manifests/up2date.pp b/manifests/up2date.pp
index 168a50b..9b6ed95 100644
--- a/manifests/up2date.pp
+++ b/manifests/up2date.pp
@@ -14,7 +14,7 @@ define base::up2date::sources($jpackage17 = false, $useRHN = false, $remi = fals
         absent: {
             file { '/etc/sysconfig/rhn/sources': ensure => absent }
         }
-        default: { crit "Invalid ensure value: $ensure" }
+        default: { crit("Invalid ensure value: $ensure") }
     }
 }
 
diff --git a/manifests/wallet/keytab.pp b/manifests/wallet/keytab.pp
index 18c8ec7..62ba85b 100644
--- a/manifests/wallet/keytab.pp
+++ b/manifests/wallet/keytab.pp
@@ -29,7 +29,7 @@ define base::wallet::keytab(
     }
     false, 'false': { }
     default: {
-      crit "Invalid value for primary: $primary (not true or false)"
+      crit("Invalid value for primary: $primary (not true or false)")
     }
   }
 }
-- 
GitLab